Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OpenAPI docs small fixes #19936

Merged
merged 1 commit into from
May 4, 2022

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 3, 2022

SUMMARY

Several small fixes on the OpenAPI specs (mainly on response codes)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #19936 (335a27a) into master (90130e4) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 335a27a differs from pull request most recent head a4756ba. Consider uploading reports for the commit a4756ba to get more accurate results

@@            Coverage Diff             @@
##           master   #19936      +/-   ##
==========================================
- Coverage   66.56%   66.53%   -0.03%     
==========================================
  Files        1714     1714              
  Lines       65043    65043              
  Branches     6723     6723              
==========================================
- Hits        43293    43277      -16     
- Misses      20037    20055      +18     
+ Partials     1713     1711       -2     
Flag Coverage Δ
hive 52.90% <ø> (ø)
mysql 81.95% <ø> (ø)
postgres 82.00% <ø> (ø)
presto 52.76% <ø> (ø)
python 82.41% <ø> (-0.01%) ⬇️
sqlite 81.76% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/api.py 85.93% <ø> (ø)
superset/dashboards/api.py 92.73% <ø> (ø)
superset/databases/api.py 94.01% <ø> (ø)
superset/embedded/api.py 93.33% <ø> (ø)
superset/importexport/api.py 100.00% <ø> (ø)
superset/reports/api.py 89.84% <ø> (ø)
superset/security/api.py 96.72% <ø> (ø)
...rd/components/nativeFilters/FilterBar/keyValue.tsx 33.33% <0.00%> (-18.52%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 60.58% <0.00%> (-7.30%) ⬇️
superset/initialization/__init__.py 91.37% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90130e4...a4756ba. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dpgaspar dpgaspar merged commit 5dd3ea1 into apache:master May 4, 2022
@dpgaspar dpgaspar deleted the fix/openapi-databases branch May 4, 2022 08:59
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants