-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate /superset/validate_sql_json migrate to api v1 #19935
feat: deprecate /superset/validate_sql_json migrate to api v1 #19935
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19935 +/- ##
==========================================
- Coverage 54.36% 54.36% -0.01%
==========================================
Files 1712 1713 +1
Lines 63968 64058 +90
Branches 6731 6731
==========================================
+ Hits 34778 34826 +48
- Misses 27479 27521 +42
Partials 1711 1711
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…idate-sql-json-to-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Go v1 API! :)
…#19935) * feat: deprecate /superset/validate_sql_json migrate to api v1 * use new error handling * migrate SQLLAb frontend and add tests * debug test * debug test * fix frontend test on sqllab * fix tests * fix frontend test on sqllab * fix tests * fix tests * fix tests * fix tests
…#19935) * feat: deprecate /superset/validate_sql_json migrate to api v1 * use new error handling * migrate SQLLAb frontend and add tests * debug test * debug test * fix frontend test on sqllab * fix tests * fix frontend test on sqllab * fix tests * fix tests * fix tests * fix tests
SUMMARY
Following plan to gradually deprecate "REST" endpoints on /superset namespace.
Deprecates
/superset/validate_sql_json
. Proposed removal on Superset 3.0New endpoint
/api/v1/database/<int:database_id>/validate_sql
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION