Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart & legend): make to enable show legend by default #19927

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented May 2, 2022

SUMMARY

Enable Legend by Default

  • For any new charts created that have a "Show Legend" option, enable it by default
  • User should be able to see the legend checkbox checked and can disable it if they want

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

screen-unable-legend-default.mov

AFTER:

screen-default.mov

TESTING INSTRUCTIONS

  1. Create New Chart.
  2. Go to Customize of Chart options
  3. Find Show Legend or Legend Option

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@Gwitchr Gwitchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #19927 (b8ddf58) into master (1fa841e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19927   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1715     1715           
  Lines       65060    65060           
  Branches     6723     6723           
=======================================
+ Hits        43272    43273    +1     
  Misses      20076    20076           
+ Partials     1712     1711    -1     
Flag Coverage Δ
javascript 51.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ns/legacy-plugin-chart-heatmap/src/controlPanel.ts 66.66% <ø> (ø)
.../legacy-plugin-chart-histogram/src/controlPanel.ts 60.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx 100.00% <ø> (ø)
...frontend/plugins/plugin-chart-echarts/src/types.ts 100.00% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 33.15% <0.00%> (ø)
...frontend/src/SqlLab/components/ResultSet/index.tsx 50.49% <0.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa841e...b8ddf58. Read the comment docs.

@rusackas rusackas merged commit 7b3d0f0 into apache:master May 2, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants