Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removes hard-coded colors from the plugins - iteration 1 #19923

Merged
merged 3 commits into from
May 9, 2022
Merged

chore: Removes hard-coded colors from the plugins - iteration 1 #19923

merged 3 commits into from
May 9, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Replaces hard-coded colors with colors from the theme
  • Fixes some storybook properties that were preventing some plugins to render
  • Fixes the theme decorator to correctly pass the theme object

TESTING INSTRUCTIONS

  • Open the plugins' storybook
  • Check the changed plugins

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 2, 2022 •
edited
Loading

Codecov Report

Merging #19923 (e9032e9) into master (e9032e9) will not change coverage.
The diff coverage is n/a.

❗ Current head e9032e9 differs from pull request most recent head cba9e21. Consider uploading reports for the commit cba9e21 to get more accurate results

@@           Coverage Diff           @@
##           master   #19923   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files        1714     1714           
  Lines       65084    65084           
  Branches     6725     6725           
=======================================
  Hits        43300    43300           
  Misses      20072    20072           
  Partials     1712     1712
Flag Coverage Δ
hive 52.89% <0.00%> (ø)
javascript 51.25% <0.00%> (ø)
mysql 81.95% <0.00%> (ø)
postgres 81.99% <0.00%> (ø)
presto 52.75% <0.00%> (ø)
python 82.41% <0.00%> (ø)
sqlite 81.75% <0.00%> (ø)
unit 48.05% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9032e9...cba9e21. Read the comment docs.

@michael-s-molina michael-s-molina force-pushed the remove-hard-coded-colors-plugins-1 branch from c3cca02 to cba9e21 Compare May 4, 2022 12:58
geido
geido approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit b7cff83 into apache:master May 9, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
@michael-s-molina
chore: Removes hard-coded colors from the plugins - iteration 1 (apac…
1251c68 
…he#19923)

* chore: Removes hard-coded colors from the plugins - iteration 1

* Fixes lint errors

* Fixes tests
@michael-s-molina michael-s-molina mentioned this pull request May 11, 2022
Merged
9 tasks
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@michael-s-molina @philipher29
chore: Removes hard-coded colors from the plugins - iteration 1 (apac…
a5edf0c 
…he#19923)

* chore: Removes hard-coded colors from the plugins - iteration 1

* Fixes lint errors

* Fixes tests
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @geido @mistercrunch