-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cannot re-order metrics by drag and drop #19876
fix: Cannot re-order metrics by drag and drop #19876
Conversation
9ca9705
to
c47f21c
Compare
Codecov Report
@@ Coverage Diff @@
## master #19876 +/- ##
==========================================
+ Coverage 66.48% 66.51% +0.03%
==========================================
Files 1713 1714 +1
Lines 64995 65030 +35
Branches 6698 6713 +15
==========================================
+ Hits 43209 43257 +48
+ Misses 20079 20065 -14
- Partials 1707 1708 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Ephemeral environment shutdown and build artifacts deleted. |
@rusackas Ephemeral environment creation failed. Please check the Actions logs for details. |
* fix: cannot-re-order-metrics-by-drag-and-drop * add tests
* fix: cannot-re-order-metrics-by-drag-and-drop * add tests
SUMMARY
The metric tooltip gets in the way of re-ordering metrics, dragging over to lower the metric in the list doesn't work.
There's an architecture already in place to handle the dragging for other scenarios. This PR expands that to include the metrics, by disabling the tooltip on drag.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
old.mov
After:
new.mov
TESTING INSTRUCTIONS
Create a chart and add to it several metrics.
Before trying to drag and drop, hover over the metric until the tooltip appears.
ADDITIONAL INFORMATION