fix: Dashboard report creation error handling #19859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We hit this error internally because we allow non owners to view dashboards that are in draft mode, but then when the report DAO returned a dashboard not found error, it crashed the page. While the true fix for us is overriding the access controls for draft mode dashboards, this is also a clear bug where the error payload may not contain a
name
attribute, and thus trying to get the first element of that isn't possible.TESTING INSTRUCTIONS
CI, will test in our local environment to verify
ADDITIONAL INFORMATION
to: @rusackas @michael-s-molina @john-bodley