Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update eslint error message to reflect location of antd components #19857

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Apr 27, 2022

SUMMARY

Fixes #19856

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @rusackas @michael-s-molina

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #19857 (fa073ff) into master (1d043e5) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19857      +/-   ##
==========================================
+ Coverage   66.30%   66.46%   +0.16%     
==========================================
  Files        1713     1713              
  Lines       64961    64961              
  Branches     6696     6696              
==========================================
+ Hits        43070    43177     +107     
+ Misses      20186    20079     -107     
  Partials     1705     1705              
Flag Coverage Δ
hive 52.87% <ø> (?)
javascript 51.15% <ø> (ø)
mysql 81.90% <ø> (ø)
postgres 81.94% <ø> (ø)
presto 52.71% <ø> (?)
python 82.37% <ø> (+0.33%) ⬆️
sqlite 81.71% <ø> (ø)
unit 47.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/core.py 89.83% <0.00%> (+0.11%) ⬆️
superset/models/core.py 89.33% <0.00%> (+0.23%) ⬆️
superset/db_engine_specs/base.py 88.35% <0.00%> (+0.33%) ⬆️
superset/connectors/sqla/models.py 90.04% <0.00%> (+1.19%) ⬆️
superset/db_engine_specs/presto.py 88.70% <0.00%> (+5.33%) ⬆️
superset/db_engine_specs/hive.py 85.82% <0.00%> (+15.70%) ⬆️
superset/db_engines/hive.py 85.18% <0.00%> (+85.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d043e5...fa073ff. Read the comment docs.

@etr2460 etr2460 merged commit 768e4b7 into master Apr 27, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the etr2460-patch-6 branch March 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import from 'antd' is not allowed but the recommended alternative does not exist
3 participants