-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Advanced Analytics into mixed time series chart #19851
Conversation
undefined, | ||
undefined, | ||
undefined, | ||
undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will open separated PR to remove undefined in QueryObject.
Codecov Report
@@ Coverage Diff @@
## master #19851 +/- ##
==========================================
- Coverage 66.55% 66.49% -0.07%
==========================================
Files 1692 1714 +22
Lines 64802 64995 +193
Branches 6657 6709 +52
==========================================
+ Hits 43129 43216 +87
- Misses 19973 20072 +99
- Partials 1700 1707 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass test + review: one minor problem with the period control visibility, but other than that works well.
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great hack 😄 LGTM, thanks for this great improvement!
SUMMARY
Added Advanced Analytics into Mixed Timeseries chart
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
TBD
ADDITIONAL INFORMATION