fix(explore): ignore temporary controls in altered pill #19843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the
AlteredSliceTag
pill appears when there are changes tourl_params
in the form data. Since these are not persisted in chart metadata (see #18960), we should ignore temporary control values when comparing old vs new form data. A test is also added to ensure the pill doesn't render when there are changes present inurl_params
.AFTER
Now the pill no longer appears when refreshing a chart with a change to
url_params
:BEFORE
Previously the pill would always appear when refreshing the chart due to
explore_form_data
and other url params being present in the URL:TESTING INSTRUCTIONS
ADDITIONAL INFORMATION