Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table chart column config issue #19841

Merged

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

This PR resolved column config issue which happened when we update the chart.

How To Check

  1. Create a table chart with custom Metric.
  2. Change the alignment in customize tab.
  3. Update the custom Metric name.
  4. Update the chart.

Previously changed alignment should be kept in the updated chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

[DEV] Add new chart - 25 April 2022 - Watch Video

TESTING INSTRUCTIONS

[DEV] Add new chart - 25 April 2022 - Watch Video

ADDITIONAL INFORMATION

  • Fix Table Chart Column Config Bug

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #19841 (840d009) into master (ae38411) will decrease coverage by 0.05%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master   #19841      +/-   ##
==========================================
- Coverage   66.55%   66.50%   -0.06%     
==========================================
  Files        1692     1714      +22     
  Lines       64802    65011     +209     
  Branches     6657     6717      +60     
==========================================
+ Hits        43129    43234     +105     
- Misses      19973    20070      +97     
- Partials     1700     1707       +7     
Flag Coverage Δ
javascript 51.24% <44.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/explore/reducers/exploreReducer.js 27.84% <44.44%> (+2.13%) ⬆️
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <0.00%> (-19.05%) ⬇️
...end/src/components/Form/LabeledErrorBoundInput.tsx 95.00% <0.00%> (-5.00%) ⬇️
...-ui-chart-controls/src/components/MetricOption.tsx 90.90% <0.00%> (-3.83%) ⬇️
...dashboard/components/SliceHeaderControls/index.tsx 66.25% <0.00%> (-0.42%) ⬇️
.../src/explore/components/DataTableControl/index.tsx 70.66% <0.00%> (-0.39%) ⬇️
...frontend/src/SqlLab/components/SqlEditor/index.jsx 51.07% <0.00%> (-0.28%) ⬇️
superset-frontend/src/components/Label/index.tsx 100.00% <0.00%> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <0.00%> (ø)
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 69.35% <0.00%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae38411...840d009. Read the comment docs.

@codemaster08240328 codemaster08240328 changed the title Fix table chart column config issue fix: Table chart column config issue Apr 25, 2022
controls: { ...state.controls, [action.controlName]: control },
controls: {
...state.controls,
[action.controlName]: control,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use controlName directly here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, we can use it.
Actually this change was made by vsCode auto lint, which means original code was like it. 🤣

@rusackas rusackas merged commit 9376940 into apache:master May 10, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
* Fix table chart column config issue

* resolve comment
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* Fix table chart column config issue

* resolve comment
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants