Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated links for country map scripts #19823

Merged
merged 1 commit into from
Apr 25, 2022
Merged

docs: updated links for country map scripts #19823

merged 1 commit into from
Apr 25, 2022

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Apr 22, 2022

SUMMARY

The instructions on adding a new country map now has broken links.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #19823 (eed0d83) into master (a1bd5b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19823   +/-   ##
=======================================
  Coverage   66.55%   66.55%           
=======================================
  Files        1692     1692           
  Lines       64801    64801           
  Branches     6657     6657           
=======================================
  Hits        43128    43128           
  Misses      19973    19973           
  Partials     1700     1700           
Flag Coverage Δ
hive 52.87% <ø> (ø)
javascript 51.25% <ø> (ø)
mysql 81.90% <ø> (ø)
postgres 81.94% <ø> (ø)
presto 52.72% <ø> (ø)
python 82.37% <ø> (ø)
sqlite 81.71% <ø> (ø)
unit 47.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1bd5b2...eed0d83. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix.

@ktmud ktmud merged commit ae38411 into master Apr 25, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the ktmud-patch-3 branch March 26, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants