Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small cleanup for created by me dashboards API #19755

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

dpgaspar
Copy link
Member

SUMMARY

A couple of cleanup's/fixes that were created on: #19434

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #19755 (2e5bb26) into master (57157c8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19755      +/-   ##
==========================================
- Coverage   66.51%   66.51%   -0.01%     
==========================================
  Files        1687     1687              
  Lines       64620    64618       -2     
  Branches     6646     6646              
==========================================
- Hits        42980    42978       -2     
  Misses      19940    19940              
  Partials     1700     1700              
Flag Coverage Δ
hive 52.69% <0.00%> (-0.01%) ⬇️
mysql 81.95% <100.00%> (-0.01%) ⬇️
postgres 82.00% <100.00%> (-0.01%) ⬇️
presto 52.54% <0.00%> (-0.01%) ⬇️
python 82.42% <100.00%> (-0.01%) ⬇️
sqlite 81.76% <100.00%> (-0.01%) ⬇️
unit 47.75% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/constants.py 100.00% <ø> (ø)
superset/dashboards/api.py 92.73% <ø> (ø)
superset/views/core.py 77.00% <100.00%> (ø)
superset/key_value/shared_entries.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57157c8...2e5bb26. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit f06db79 into apache:master Apr 20, 2022
@dpgaspar dpgaspar deleted the fix/dashboard-api branch April 20, 2022 11:11
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants