-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplify SQLite time grain #19745
feat: simplify SQLite time grain #19745
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19745 +/- ##
==========================================
- Coverage 66.51% 66.36% -0.15%
==========================================
Files 1684 1714 +30
Lines 64560 65052 +492
Branches 6625 6722 +97
==========================================
+ Hits 42939 43171 +232
- Misses 19926 20169 +243
- Partials 1695 1712 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
117e530
to
de0d78f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice tests! 😮 👍 That's probably a pattern we should invest more in to isolate engine-specific tests in the unit test suite. LGTM
SUMMARY
The current expression for quarter time grain in SQLite is horrible and I found a way of simplifying it. I also added more time grains, and cleaned all of them so that the return type is consistent (
DATETIME
).BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Added unit tests.
ADDITIONAL INFORMATION