Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 10/15/30 min grain to Pinot #19724

Merged
merged 2 commits into from
Apr 19, 2022
Merged

feat: 10/15/30 min grain to Pinot #19724

merged 2 commits into from
Apr 19, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Apr 14, 2022

SUMMARY

Adding new time grains to Pinot

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #19724 (6351927) into master (ac2c66c) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 6351927 differs from pull request most recent head 4f94399. Consider uploading reports for the commit 4f94399 to get more accurate results

@@            Coverage Diff             @@
##           master   #19724      +/-   ##
==========================================
- Coverage   66.51%   66.32%   -0.19%     
==========================================
  Files        1686     1686              
  Lines       64589    64589              
  Branches     6635     6635              
==========================================
- Hits        42959    42838     -121     
- Misses      19931    20052     +121     
  Partials     1699     1699              
Flag Coverage Δ
hive ?
mysql 81.95% <ø> (ø)
postgres 82.00% <ø> (ø)
presto ?
python 82.05% <ø> (-0.39%) ⬇️
sqlite ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/pinot.py 97.36% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.11% <0.00%> (-15.71%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/db_engine_specs/presto.py 83.64% <0.00%> (-5.39%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/connectors/sqla/utils.py 88.76% <0.00%> (-2.25%) ⬇️
superset/result_set.py 96.77% <0.00%> (-1.62%) ⬇️
superset/databases/commands/test_connection.py 98.57% <0.00%> (-1.43%) ⬇️
superset/connectors/sqla/models.py 88.24% <0.00%> (-1.22%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2c66c...4f94399. Read the comment docs.

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @hughhhh was going to try to test these time grains with a Pinot db, but this lgtm.

@hughhhh
Copy link
Member Author

hughhhh commented Apr 19, 2022

Verified new grains are working! 🥳

Screen Shot 2022-04-19 at 11 11 32 AM

@hughhhh hughhhh merged commit a6f4601 into master Apr 19, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* add new grains to pinot

* update test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the add-time-grains-pinot branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants