-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: UI override registry #19671
feat: UI override registry #19671
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19671 +/- ##
==========================================
- Coverage 66.47% 66.46% -0.01%
==========================================
Files 1681 1683 +2
Lines 64467 64459 -8
Branches 6607 6609 +2
==========================================
- Hits 42856 42845 -11
- Misses 19917 19920 +3
Partials 1694 1694
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* typed registry * remove unintentional change * lint * fix (cherry picked from commit 4927685)
🏷️ preset:2022.15 |
* typed registry * remove unintentional change * lint * fix
SUMMARY
When serving Superset, there are many cases where it may be desirable to customize specific UI elements. This PR introduces a UiOverrideRegistry for that purpose.
The new
TypedRegistry
is better suited for this than the existing Registry class, because different keys can have different types of values, and all the keys offered by Superset are enumerated here.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION