Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions cleanup: remove none and duplicates. #1967

Merged
merged 1 commit into from
Jan 13, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Permissions cleanup: remove none and duplicates.
  • Loading branch information
Bogdan Kyryliuk committed Jan 13, 2017
commit 4d03acf34f29260eeb0ab729dc2410b5176fcad0
50 changes: 50 additions & 0 deletions scripts/permissions_cleanup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
from superset import sm
from collections import defaultdict


def cleanup_permissions():
# 1. Clean up duplicates.
pvms = sm.get_session.query(sm.permissionview_model).all()
print('# of permission view menues is: {}'.format(len(pvms)))
pvms_dict = defaultdict(list)
for pvm in pvms:
pvms_dict[(pvm.permission, pvm.view_menu)].append(pvm)
duplicates = [v for v in pvms_dict.values() if len(v) > 1]
len(duplicates)

for pvm_list in duplicates:
first_prm = pvm_list[0]
roles = set(first_prm.role)
for pvm in pvm_list[1:]:
roles = roles.union(pvm.role)
sm.get_session.delete(pvm)
first_prm.roles = list(roles)
sm.get_session.commit()

pvms = sm.get_session.query(sm.permissionview_model).all()
print('STage 1: # of permission view menues is: {}'.format(len(pvms)))

# 2. Clean up None permissions or view menues
pvms = sm.get_session.query(sm.permissionview_model).all()
for pvm in pvms:
if not (pvm.view_menu and pvm.permission):
sm.get_session.delete(pvm)
sm.get_session.commit()

pvms = sm.get_session.query(sm.permissionview_model).all()
print('Stage 2: # of permission view menues is: {}'.format(len(pvms)))

# 3. Delete empty permission view menues from roles
roles = sm.get_session.query(sm.role_model).all()
for role in roles:
role.permissions = [p for p in role.permissions if p]
sm.get_session.commit()

# 4. Delete empty roles from permission view menues
pvms = sm.get_session.query(sm.permissionview_model).all()
for pvm in pvms:
pvm.role = [r for r in pvm.role if r]
sm.get_session.commit()


cleanup_permissions()