Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(explore): Change labels "Group by"/"Series" to "Dimensions" #19647

Merged
merged 1 commit into from
Apr 13, 2022
Merged

chore(explore): Change labels "Group by"/"Series" to "Dimensions" #19647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/dndControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import { TIME_COLUMN_OPTION, TIME_FILTER_LABELS } from '../constants';

export const dndGroupByControl: SharedControlConfig<'DndColumnSelect'> = {
type: 'DndColumnSelect',
label: t('Group by'),
label: t('Dimensions'),
default: [],
description: t(
'One or many columns to group by. High cardinality groupings should include a series limit ' +
Expand Down Expand Up @@ -58,7 +58,7 @@ export const dndColumnsControl: typeof dndGroupByControl = {

export const dndSeries: typeof dndGroupByControl = {
...dndGroupByControl,
label: t('Series'),
label: t('Dimensions'),
multi: false,
default: null,
description: t(
Expand Down
4 changes: 2 additions & 2 deletions superset-frontend/packages/superset-ui-chart-controls/src/shared-controls/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ type SelectDefaultOption = {

const groupByControl: SharedControlConfig<'SelectControl', ColumnMeta> = {
type: 'SelectControl',
label: t('Group by'),
label: t('Dimensions'),
multi: true,
freeForm: true,
clearable: true,
Expand Down Expand Up @@ -403,7 +403,7 @@ const sort_by: SharedControlConfig<'MetricsControl'> = {

const series: typeof groupByControl = {
...groupByControl,
label: t('Series'),
label: t('Dimensions'),
multi: false,
default: null,
description: t(
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/plugins/legacy-preset-chart-nvd3/src/DistBar/controlPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ const config: ControlPanelConfig = {
],
controlOverrides: {
groupby: {
label: t('Series'),
label: t('Dimensions'),
validators: [validateNonEmpty],
mapStateToProps: (state, controlState) => {
const groupbyProps =
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/plugins/plugin-chart-echarts/src/BoxPlot/controlPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ const config: ControlPanelConfig = {
],
controlOverrides: {
groupby: {
label: t('Series'),
label: t('Dimensions'),
description: t('Categories to group by on the x-axis.'),
},
columns: {
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/plugins/plugin-chart-echarts/src/Gauge/controlPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const config: ControlPanelConfig = {
name: 'groupby',
config: {
...sharedControls.groupby,
label: t('Group by'),
label: t('Dimensions'),
description: t('Columns to group by'),
},
},
Expand Down
4 changes: 2 additions & 2 deletions superset-frontend/src/explore/controls.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ const groupByControl = {
type: 'SelectControl',
multi: true,
freeForm: true,
label: t('Group by'),
label: t('Dimensions'),
default: [],
includeTime: false,
description: t(
Expand Down Expand Up @@ -393,7 +393,7 @@ export const controls = {

series: {
...groupByControl,
label: t('Series'),
label: t('Dimensions'),
multi: false,
default: null,
description: t(
Expand Down