Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: consistent migration tests organization #19635

Merged
merged 1 commit into from
Apr 9, 2022

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Apr 9, 2022

SUMMARY

Small house-keeping to organize integration tests for migrations in a consistent manner.

  1. Use full migration name in filenames
  2. Use "__tests" as suffix to make filenames easier to read
  3. Move one test from integration_tests/migration_tests to a new file following above convention

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #19635 (029193b) into master (9a9e3b6) will decrease coverage by 12.83%.
The diff coverage is n/a.

❗ Current head 029193b differs from pull request most recent head c497e6f. Consider uploading reports for the commit c497e6f to get more accurate results

@@             Coverage Diff             @@
##           master   #19635       +/-   ##
===========================================
- Coverage   66.49%   53.65%   -12.84%     
===========================================
  Files        1681     1681               
  Lines       64370    64370               
  Branches     6583     6583               
===========================================
- Hits        42803    34538     -8265     
- Misses      19886    28151     +8265     
  Partials     1681     1681               
Flag Coverage Δ
hive ?
mysql ?
postgres ?
presto 52.51% <ø> (ø)
python 56.23% <ø> (-26.15%) ⬇️
sqlite ?
unit 47.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/upsert.py 0.00% <0.00%> (-89.59%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-89.37%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 14.79% <0.00%> (-75.15%) ⬇️
superset/datasets/commands/importers/v0.py 24.82% <0.00%> (-68.80%) ⬇️
superset/databases/commands/test_connection.py 31.42% <0.00%> (-68.58%) ⬇️
superset/datasets/commands/update.py 25.88% <0.00%> (-68.24%) ⬇️
... and 265 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a9e3b6...c497e6f. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the cleanup.

@ktmud ktmud merged commit b45f89b into apache:master Apr 9, 2022
@john-bodley john-bodley deleted the re-organize-migrations-tests branch June 8, 2022 05:32
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants