Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update line-height in SliceHeaderControl #19613

Merged
merged 2 commits into from
Apr 28, 2022
Merged

chore: Update line-height in SliceHeaderControl #19613

merged 2 commits into from
Apr 28, 2022

Conversation

geido
Copy link
Member

@geido geido commented Apr 8, 2022

SUMMARY

Removes a hacky usage of font-size and sets the line-height to a fixed value. Line heights will soon be converted to theme variables in a follow-up effort.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes

TESTING INSTRUCTIONS

No changes should be observable

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #19613 (65076e4) into master (4a835a4) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19613      +/-   ##
==========================================
- Coverage   66.51%   66.50%   -0.01%     
==========================================
  Files        1714     1714              
  Lines       65026    65025       -1     
  Branches     6710     6710              
==========================================
- Hits        43249    43248       -1     
  Misses      20070    20070              
  Partials     1707     1707              
Flag Coverage Δ
javascript 51.22% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dashboard/components/SliceHeaderControls/index.tsx 66.25% <ø> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a835a4...65076e4. Read the comment docs.

@geido geido added the global:theming Related to theming Superset label Apr 8, 2022
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the note that we will come back in a follow-up when the line-height is added to the theme object.

@geido geido merged commit 1d50665 into apache:master Apr 28, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants