Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add empty states to sqlab editor and select #19598

Merged
merged 31 commits into from
Apr 15, 2022
Merged

feat: add empty states to sqlab editor and select #19598

Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
7dadc58
feat: add empty states to sqlab editor and select
pkdotson Apr 7, 2022
d9984ea
add suggestions and test
pkdotson Apr 11, 2022
aa5e8bc
update type
pkdotson Apr 11, 2022
5d04b36
Merge branch 'master' of https://github.com/preset-io/superset into f…
pkdotson Apr 11, 2022
cd4abf9
lint fix and add suggestions
pkdotson Apr 11, 2022
e417d79
fix typo
pkdotson Apr 11, 2022
d088f14
run lint
pkdotson Apr 11, 2022
68d5827
remove unused code
pkdotson Apr 11, 2022
bae0137
fix test
pkdotson Apr 12, 2022
bdcda07
remove redux for propagation and other suggestions
pkdotson Apr 13, 2022
efcdf4b
add t
pkdotson Apr 13, 2022
7f15b18
Merge branch 'master' of https://github.com/preset-io/superset into f…
pkdotson Apr 13, 2022
61ee6c6
lint
pkdotson Apr 13, 2022
7255d35
fix text and remove code
pkdotson Apr 13, 2022
19283db
ts and fix t in p
pkdotson Apr 13, 2022
dbed5fe
fix spelling
pkdotson Apr 13, 2022
f1eba19
remove unused prop
pkdotson Apr 13, 2022
7bca734
add fn to prop change state
pkdotson Apr 14, 2022
a586d38
remove unused code
pkdotson Apr 14, 2022
a5c5bf2
remove unused types
pkdotson Apr 14, 2022
c705ce6
update code and test
pkdotson Apr 15, 2022
94d3485
fix lint
pkdotson Apr 15, 2022
d222fea
fix ts
pkdotson Apr 15, 2022
66e9c46
update ts
pkdotson Apr 15, 2022
8bd7cf6
add type export and fix test
pkdotson Apr 15, 2022
9adc5ea
Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index…
pkdotson Apr 15, 2022
2a4995c
Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index…
pkdotson Apr 15, 2022
8217c2c
Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index…
pkdotson Apr 15, 2022
925e107
Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index…
pkdotson Apr 15, 2022
bf36826
remove handlerror and unused code
pkdotson Apr 15, 2022
b628c7c
Merge branch 'feat-blackstate-sql1' of https://github.com/preset-io/s…
pkdotson Apr 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index… 
….tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
  • Loading branch information
@pkdotson @michael-s-molina
pkdotson and michael-s-molina authored Apr 15, 2022
commit 9adc5eab95296104b20c0744559d27e4043428ab
2 changes: 1 addition & 1 deletion superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export default function SqlEditorLeftBar({
// Ref needed to avoid infinite rerenders on handlers
// that require and modify the queryEditor
const queryEditorRef = useRef<QueryEditor>(queryEditor);
const [isDbSearch, setDbSearch] = useState(false);
const [emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false);

useEffect(() => {
queryEditorRef.current = queryEditor;
Expand Down