-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Removes the CSS files from the Horizon plugin #19562
refactor: Removes the CSS files from the Horizon plugin #19562
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19562 +/- ##
==========================================
+ Coverage 66.65% 66.68% +0.02%
==========================================
Files 1680 1681 +1
Lines 64292 64303 +11
Branches 6564 6565 +1
==========================================
+ Hits 42854 42878 +24
+ Misses 19736 19730 -6
+ Partials 1702 1695 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
superset-frontend/plugins/legacy-plugin-chart-horizon/src/HorizonChart.jsx
Outdated
Show resolved
Hide resolved
5da279e
to
9f9b9f4
Compare
* refactor: Removes the CSS files from the Horizon plugin * Removes the CSS file * Uses font-size from the theme
SUMMARY
This PR removes the CSS files from the Horizon plugin using Emotion. It also adjusts the styles to match theme configuration and existing components.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.
ADDITIONAL INFORMATION