Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removes the CSS files from the Horizon plugin #19562

Merged
merged 3 commits into from
Apr 7, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR removes the CSS files from the Horizon plugin using Emotion. It also adjusts the styles to match theme configuration and existing components.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-04-06 at 9 40 55 AM

Screen Shot 2022-04-06 at 9 53 35 AM

TESTING INSTRUCTIONS

Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #19562 (f7d2c5d) into master (f91f83d) will increase coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head f7d2c5d differs from pull request most recent head 9f9b9f4. Consider uploading reports for the commit 9f9b9f4 to get more accurate results

@@            Coverage Diff             @@
##           master   #19562      +/-   ##
==========================================
+ Coverage   66.65%   66.68%   +0.02%     
==========================================
  Files        1680     1681       +1     
  Lines       64292    64303      +11     
  Branches     6564     6565       +1     
==========================================
+ Hits        42854    42878      +24     
+ Misses      19736    19730       -6     
+ Partials     1702     1695       -7     
Flag Coverage Δ
javascript 51.51% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-horizon/src/HorizonChart.jsx 0.00% <0.00%> (ø)
...ntend/packages/superset-ui-core/src/color/utils.ts 97.14% <0.00%> (-2.86%) ⬇️
...ins/legacy-plugin-chart-partition/src/Partition.js 0.00% <0.00%> (ø)
...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx 0.00% <0.00%> (ø)
...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx 0.00% <0.00%> (ø)
...rt-parallel-coordinates/src/ParallelCoordinates.js 0.00% <0.00%> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
...gacy-plugin-chart-partition/src/ReactPartition.jsx 0.00% <0.00%> (ø)
...rontend/src/visualizations/FilterBox/FilterBox.jsx 48.85% <0.00%> (+1.19%) ⬆️
superset-frontend/src/components/Select/utils.ts 63.15% <0.00%> (+5.26%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f91f83d...9f9b9f4. Read the comment docs.

@michael-s-molina michael-s-molina added the global:theming Related to theming Superset label Apr 7, 2022
@michael-s-molina michael-s-molina merged commit d511e4f into apache:master Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* refactor: Removes the CSS files from the Horizon plugin

* Removes the CSS file

* Uses font-size from the theme
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants