Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GSheets rendering from global nav #19519

Merged
merged 1 commit into from
Apr 4, 2022
Merged

fix: GSheets rendering from global nav #19519

merged 1 commit into from
Apr 4, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Apr 4, 2022

SUMMARY

Small change needed to for the Gsheets button in the dropdown to work.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: 2 options inside top right '+' button not working #20072
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh
Copy link
Member Author

hughhhh commented Apr 4, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

@hughhhh Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details.

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #19519 (14babdd) into master (4b92287) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19519      +/-   ##
==========================================
- Coverage   66.59%   66.59%   -0.01%     
==========================================
  Files        1678     1678              
  Lines       64242    64244       +2     
  Branches     6539     6539              
==========================================
  Hits        42784    42784              
- Misses      19763    19765       +2     
  Partials     1695     1695              
Flag Coverage Δ
hive 52.69% <ø> (ø)
javascript 51.34% <ø> (-0.01%) ⬇️
mysql 81.90% <ø> (ø)
postgres 81.95% <ø> (ø)
presto 52.54% <ø> (ø)
python 82.38% <ø> (-0.01%) ⬇️
sqlite 81.72% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/views/components/MenuRight.tsx 67.69% <ø> (ø)
superset/initialization/__init__.py 91.28% <0.00%> (-0.35%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (ø)
...src/components/FilterableTable/FilterableTable.tsx 71.42% <0.00%> (ø)
...allel-coordinates/src/ReactParallelCoordinates.jsx 0.00% <0.00%> (ø)
...rc/SqlLab/components/ScheduleQueryButton/index.tsx 20.75% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b92287...14babdd. Read the comment docs.

@lyndsiWilliams
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

@lyndsiWilliams Ephemeral environment spinning up at http://35.165.158.102:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled the branch locally and it shows up as described
Screen Shot 2022-04-04 at 12 41 56 PM

@hughhhh hughhhh merged commit c2fae82 into master Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 6, 2022
(cherry picked from commit c2fae82)
@sadpandajoe
Copy link
Member

🏷️ preset:2022.13

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the fix-gsheets branch March 26, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.13 size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants