Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alert/report created by filter inconsistency with table display #19518

Merged

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

The Alert/Report list doesn't have a creator column, yet there's a "created by" filter for it.
This creates an inconsistency for the user, that has a filter that is not visually represented in the table.
Furthermore, the table has some inconsistencies in the display with other tables in the system around these fields, like the dashboard ones.

This PR solves both, by adding the created by field to the table & allow the user to sort by both created by and owners.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-04-04.at.13.06.53.mov

After:

Screen.Recording.2022-04-04.at.13.03.03.mov

TESTING INSTRUCTIONS

  1. Go to the reports view
  2. Add one report with user A (current user) as owner
  3. Add one report with user A & user B as owners

Ensure that the owner & created by fields display correctly.
Ensure that the owner & created by filters work by filtering by their respective fields accordingly.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #19518 (c1d2956) into master (2de5e6f) will decrease coverage by 0.01%.
The diff coverage is 6.66%.

❗ Current head c1d2956 differs from pull request most recent head 891dd22. Consider uploading reports for the commit 891dd22 to get more accurate results

@@            Coverage Diff             @@
##           master   #19518      +/-   ##
==========================================
- Coverage   66.66%   66.64%   -0.02%     
==========================================
  Files        1678     1680       +2     
  Lines       64261    64272      +11     
  Branches     6561     6562       +1     
==========================================
  Hits        42837    42837              
- Misses      19723    19733      +10     
- Partials     1701     1702       +1     
Flag Coverage Δ
javascript 51.44% <6.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../legacy-plugin-chart-country-map/src/CountryMap.js 0.00% <ø> (ø)
...y-plugin-chart-country-map/src/ReactCountryMap.jsx 0.00% <0.00%> (ø)
...y-plugin-chart-sankey-loop/src/ReactSankeyLoop.jsx 0.00% <0.00%> (ø)
.../legacy-plugin-chart-sankey-loop/src/SankeyLoop.js 0.00% <ø> (ø)
...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 60.39% <0.00%> (-0.35%) ⬇️
superset/models/sql_lab.py 91.55% <ø> (ø)
superset/reports/api.py 89.84% <ø> (ø)
...perset-frontend/src/views/CRUD/alert/AlertList.tsx 66.32% <33.33%> (-1.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4baa82...891dd22. Read the comment docs.

@diegomedina248 diegomedina248 force-pushed the fix/alert-report-list-owner-created-by branch from 13f94e9 to 26838ba Compare April 5, 2022 23:51
@diegomedina248 diegomedina248 force-pushed the fix/alert-report-list-owner-created-by branch from 26838ba to 891dd22 Compare April 6, 2022 11:01
@rusackas rusackas merged commit a05ff5e into apache:master Apr 18, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…pache#19518)

* fix: alert/report created by filter inconsistency with table display

* Match column order to dashboard list
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants