Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add theme color to ParallelCoordinates #19490

Merged
merged 1 commit into from
Apr 4, 2022
Merged

chore: Add theme color to ParallelCoordinates #19490

merged 1 commit into from
Apr 4, 2022

Conversation

geido
Copy link
Member

@geido geido commented Apr 1, 2022 •
edited
Loading

SUMMARY

Removes a hex color from the style and adds a theme color instead

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes

TESTING INSTRUCTIONS

  1. Open a Parallel Coordinates chart
  2. Make sure there are no observable visual changes. Colors might be slightly adjusted to use the theme available ones.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

michael-s-molina
michael-s-molina approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit 4b92287 into apache:master Apr 4, 2022
@geido geido added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@geido @philipher29
Add theme color (apache#19490)
243eb11
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/XS 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geido @michael-s-molina @mistercrunch