Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removes the CSS files from the Sunburst plugin #19488

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR removes the CSS files from the Sunburst plugin using Emotion. It also adjusts the styles to match theme configuration and existing components.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-04-01 at 11 08 57 AM

Screen Shot 2022-04-01 at 11 25 15 AM

TESTING INSTRUCTIONS

Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #19488 (a5b1568) into master (11bf0d0) will increase coverage by 0.00%.
The diff coverage is 53.84%.

❗ Current head a5b1568 differs from pull request most recent head d112f56. Consider uploading reports for the commit d112f56 to get more accurate results

@@           Coverage Diff           @@
##           master   #19488   +/-   ##
=======================================
  Coverage   66.59%   66.59%           
=======================================
  Files        1676     1677    +1     
  Lines       64191    64215   +24     
  Branches     6525     6537   +12     
=======================================
+ Hits        42746    42762   +16     
- Misses      19746    19754    +8     
  Partials     1699     1699           
Flag Coverage Δ
javascript 51.32% <53.84%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...legacy-plugin-chart-sunburst/src/ReactSunburst.jsx 0.00% <0.00%> (ø)
...ugins/legacy-plugin-chart-sunburst/src/Sunburst.js 0.00% <ø> (ø)
...erset-frontend/src/components/EmptyState/index.tsx 74.35% <ø> (+5.12%) ⬆️
...d/components/DashboardBuilder/DashboardBuilder.tsx 70.88% <0.00%> (-1.85%) ⬇️
...rontend/src/dashboard/containers/DashboardGrid.jsx 100.00% <ø> (ø)
...rontend/src/dashboard/components/DashboardGrid.jsx 62.50% <50.00%> (-0.55%) ⬇️
...nd/src/dashboard/components/gridComponents/Tab.jsx 83.67% <100.00%> (+3.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11bf0d0...d112f56. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 4730802 into apache:master Apr 4, 2022
@michael-s-molina michael-s-molina added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants