-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add success toast to alerts and reports #19482
feat: add success toast to alerts and reports #19482
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19482 +/- ##
==========================================
+ Coverage 66.65% 66.68% +0.02%
==========================================
Files 1680 1681 +1
Lines 64292 64303 +11
Branches 6564 6565 +1
==========================================
+ Hits 42854 42878 +24
+ Misses 19736 19730 -6
+ Partials 1702 1695 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@yousoph Ephemeral environment spinning up at http://35.88.112.154:8080. Credentials are |
/testenv up FEATURE_ALERT_REPORTS=True |
@yousoph Ephemeral environment spinning up at http://18.236.135.58:8080. Credentials are |
…eat-alertsandreports-feedback
Ephemeral environment shutdown and build artifacts deleted. |
* feat: add success toast to alerts and reports * remove console * add suggestions
SUMMARY
This pr adds success messaging toast when user updates or creates an report or alert.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-03-31.at.11.44.15.PM.mov
Screen.Recording.2022-03-31.at.11.42.58.PM.mov
TESTING INSTRUCTIONS
Create and edit an alert and report and view the success toasts.
ADDITIONAL INFORMATION