Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Removes the CSS files from the Rose plugin #19473

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR removes the CSS files from the Rose plugin using Emotion. It also adjusts the styles to match theme configuration and existing components.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-03-31 at 3 01 53 PM

Screen Shot 2022-03-31 at 3 30 52 PM

TESTING INSTRUCTIONS

Check that the plugin is very similar to the previous version. We may have color, font, and opacity differences due to theme adjustments.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #19473 (802b212) into master (85e330e) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 802b212 differs from pull request most recent head 9577f79. Consider uploading reports for the commit 9577f79 to get more accurate results

@@            Coverage Diff             @@
##           master   #19473      +/-   ##
==========================================
- Coverage   66.56%   66.56%   -0.01%     
==========================================
  Files        1676     1677       +1     
  Lines       64106    64112       +6     
  Branches     6519     6519              
==========================================
  Hits        42673    42673              
- Misses      19742    19748       +6     
  Partials     1691     1691              
Flag Coverage Δ
javascript 51.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugins/legacy-plugin-chart-rose/src/ReactRose.jsx 0.00% <0.00%> (ø)
...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e330e...9577f79. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 5fed10d into apache:master Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

@geido Ephemeral environment spinning up at http://34.220.51.29:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina michael-s-molina added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/L 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants