Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error Message is cut off in alerts & reports log page #19444

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix: Error Message is cut off in alerts & reports log page #19444

merged 1 commit into from
Apr 6, 2022

Conversation

codemaster08240328
Copy link
Contributor

@codemaster08240328 codemaster08240328 commented Mar 30, 2022 •
edited
Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

AFTER:
image

TESTING INSTRUCTIONS

  1. Go to reports & alerts log page.
  2. Check Error Message.
  3. It should be wrapped by tooltip.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #19444 (b4eb2c5) into master (a4c261d) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #19444      +/-   ##
==========================================
- Coverage   66.59%   66.59%   -0.01%     
==========================================
  Files        1670     1670              
  Lines       63888    63890       +2     
  Branches     6510     6511       +1     
==========================================
+ Hits        42544    42545       +1     
- Misses      19655    19656       +1     
  Partials     1689     1689
Flag Coverage Δ
javascript 51.33% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx 80.95% <50.00%> (-3.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c261d...b4eb2c5. Read the comment docs.

diegomedina248
diegomedina248 reviewed Mar 30, 2022
View reviewed changes
superset-frontend/src/views/CRUD/alert/ExecutionLog.tsx
@@ -144,6 +145,15 @@ function ExecutionLog({ addDangerToast, isReportEnabled }: ExecutionLogProps) {
{
accessor: 'error_message',
Header: t('Error message'),
Cell: ({
row: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure all rows are objects that have an original nested object?
If not, this could fail, and maybe we need to use optional chaining instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, @diegomedina248 , all rows have the nested object which contains original.
We can confirm this from line# 133. (https://github.com/apache/superset/pull/19444/files#diff-b0502ccd40e521f12fa41224e8486ad60145cbccb955f2122c1a4da6f5904081R133)

rusackas
rusackas approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rusackas rusackas merged commit 156ac7d into apache:master Apr 6, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@codemaster08240328 @philipher29
fix: Error Message is cut off in alerts & reports log page (apache#19444
c8361b9 
)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomedina248 diegomedina248 diegomedina248 approved these changes

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/S 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codemaster08240328 @rusackas @diegomedina248 @mistercrunch