Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused less file from profile #19413

Merged
merged 2 commits into from
Apr 5, 2022
Merged

chore: Remove unused less file from profile #19413

merged 2 commits into from
Apr 5, 2022

Conversation

geido
Copy link
Member

@geido geido commented Mar 29, 2022

SUMMARY

It removes the unused main.less file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes

TESTING INSTRUCTIONS

  1. Visit the profile
  2. Make sure there are no visual changes

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #19413 (07e783c) into master (4b92287) will increase coverage by 12.61%.
The diff coverage is n/a.

❗ Current head 07e783c differs from pull request most recent head e2ea820. Consider uploading reports for the commit e2ea820 to get more accurate results

@@             Coverage Diff             @@
##           master   #19413       +/-   ##
===========================================
+ Coverage   53.87%   66.48%   +12.61%     
===========================================
  Files        1678     1670        -8     
  Lines       64242    63968      -274     
  Branches     6539     6512       -27     
===========================================
+ Hits        34612    42531     +7919     
+ Misses      27935    19748     -8187     
+ Partials     1695     1689        -6     
Flag Coverage Δ
javascript 51.32% <ø> (-0.03%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/profile/App.tsx 0.00% <ø> (ø)
superset/migrations/shared/utils.py 0.00% <0.00%> (-82.06%) ⬇️
superset/connectors/sqla/views.py 63.67% <0.00%> (-23.32%) ⬇️
...uperset-frontend/src/explore/exploreUtils/index.js 63.90% <0.00%> (-17.12%) ⬇️
superset-frontend/src/utils/urlUtils.ts 36.73% <0.00%> (-10.21%) ⬇️
...erset-frontend/src/components/EmptyState/index.tsx 69.23% <0.00%> (-5.13%) ⬇️
superset-frontend/src/components/Icons/Icon.tsx 95.23% <0.00%> (-4.77%) ⬇️
...nd/src/dashboard/components/gridComponents/Tab.jsx 80.48% <0.00%> (-3.19%) ⬇️
...rset-frontend/src/hooks/apiResources/dashboards.ts 33.33% <0.00%> (-3.04%) ⬇️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 55.14% <0.00%> (-2.96%) ⬇️
... and 354 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b92287...e2ea820. Read the comment docs.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit e391a83 into apache:master Apr 5, 2022
@geido geido added the global:theming Related to theming Superset label Apr 7, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels global:theming Related to theming Superset size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants