-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): Implement empty states for empty tabs #19408
Conversation
e72f97f
to
a411a83
Compare
a411a83
to
a37a870
Compare
a37a870
to
8357c95
Compare
Codecov Report
@@ Coverage Diff @@
## master #19408 +/- ##
=======================================
Coverage 66.57% 66.58%
=======================================
Files 1675 1675
Lines 64092 64112 +20
Branches 6519 6531 +12
=======================================
+ Hits 42672 42688 +16
- Misses 19729 19733 +4
Partials 1691 1691
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
const creteProps = () => ({ | ||
const createProps = () => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* feat(dashboard): Implement empty states in empty tabs * Change button to in text link * Add edit dashboard button to dashboard empty state * Add tests * Fix test
SUMMARY
Add empty state to dashboard tabs (top level and normal ones) if they contain no components
Moreover, I added "Edit dashboard" button to 1 of old empty states (whole dashboard is empty) for consistency.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2022-03-29.at.14.34.12.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @kasiazjc