chore: simplify error messaging in database modal #19165

pkdotson · 2022-03-16T01:55:21Z

SUMMARY

This pr removes the error alert popup in the database modal when the inline message and dberror are the same. This pr also fixes a bug where user can connect to db without name and or uri.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Go to database modal for googlesheet and try to create error mesages by either not including the name or correct uri.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

pkdotson · 2022-03-16T22:33:54Z

/testenv up

github-actions · 2022-03-16T22:36:01Z

@pkdotson Ephemeral environment spinning up at http://52.24.255.86:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

…hore-dbconnmodal-errormsg

codecov · 2022-03-31T05:36:19Z

Codecov Report

Merging #19165 (1439bc7) into master (fa68036) will decrease coverage by 0.18%.
The diff coverage is 12.50%.

❗ Current head 1439bc7 differs from pull request most recent head 37b500b. Consider uploading reports for the commit 37b500b to get more accurate results

@@            Coverage Diff             @@
##           master   #19165      +/-   ##
==========================================
- Coverage   66.54%   66.36%   -0.19%     
==========================================
  Files        1692     1691       -1     
  Lines       64807    64778      -29     
  Branches     6661     6651      -10     
==========================================
- Hits        43129    42991     -138     
- Misses      19978    20087     +109     
  Partials     1700     1700

Flag	Coverage Δ
hive	`?`
mysql	`81.90% <ø> (ø)`
postgres	`81.94% <ø> (ø)`
presto	`?`
python	`82.03% <ø> (-0.34%)`	⬇️
sqlite	`81.71% <ø> (ø)`
unit	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...abaseModal/DatabaseConnectionForm/TableCatalog.tsx	`10.00% <ø> (ø)`
superset-frontend/src/views/CRUD/hooks.ts	`46.15% <0.00%> (-0.26%)`	⬇️
superset/db_engine_specs/gsheets.py	`75.51% <ø> (ø)`
...c/views/CRUD/data/database/DatabaseModal/index.tsx	`32.51% <14.28%> (+0.34%)`	⬆️
superset/db_engines/hive.py	`0.00% <0.00%> (-85.19%)`	⬇️
superset/db_engine_specs/hive.py	`70.11% <0.00%> (-15.71%)`	⬇️
...-frontend/src/components/CronPicker/CronPicker.tsx	`85.71% <0.00%> (-14.29%)`	⬇️
...CRUD/alert/components/AlertReportCronScheduler.tsx	`76.92% <0.00%> (-10.58%)`	⬇️
superset/db_engine_specs/presto.py	`83.36% <0.00%> (-5.34%)`	⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx	`78.65% <0.00%> (-3.91%)`	⬇️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa68036...37b500b. Read the comment docs.

…hore-dbconnmodal-errormsg

github-actions · 2022-04-01T02:00:51Z

Ephemeral environment shutdown and build artifacts deleted.

pkdotson · 2022-04-01T17:01:15Z

/testenv up

yousoph · 2022-04-01T18:55:17Z

/testenv up

github-actions · 2022-04-01T19:12:48Z

@pkdotson Ephemeral environment spinning up at http://54.200.93.201:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions · 2022-04-01T19:18:47Z

@yousoph Ephemeral environment spinning up at http://34.221.20.109:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

AAfghahi · 2022-04-12T18:17:56Z

...-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm/TableCatalog.tsx

@@ -34,7 +34,6 @@ export const TableCatalog = ({
 }: FieldPropTypes) => {
  const tableCatalog = db?.catalog || [];
  const catalogError = validationErrors || {};
-


nit: Could we add this space back since it is the only change in this file.

…hore-dbconnmodal-errormsg

yousoph · 2022-04-20T18:59:23Z

/testenv up

github-actions · 2022-04-20T19:45:23Z

@yousoph Ephemeral environment spinning up at http://35.164.153.181:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

…hore-dbconnmodal-errormsg

github-actions · 2022-04-21T19:49:44Z

Ephemeral environment shutdown and build artifacts deleted.

* testing for dbconn modal error message * remove consoles and error alert mapping * lint fix * update url message * add modal fix * update comments * fix err msg bugs * fix pylint * fix line * fix tests * fix assertions

pkdotson added 2 commits March 15, 2022 18:11

testing for dbconn modal error message

e5b1ca2

remove consoles and error alert mapping

2f37f40

superset-github-bot bot added the preset-io label Mar 16, 2022

pull-request-size bot added the size/M label Mar 16, 2022

pkdotson changed the title ~~WIP: simplify error messaging in database modal~~ chore(WIP): simplify error messaging in database modal Mar 16, 2022

lint fix

df138d1

pkdotson requested review from hughhhh and AAfghahi March 16, 2022 22:06

pkdotson added 3 commits March 21, 2022 16:26

Merge branch 'master' of https://github.com/preset-io/superset into c…

6127e6d

…hore-dbconnmodal-errormsg

update url message

4d9cfe1

Merge branch 'master' of https://github.com/preset-io/superset into c…

2167348

…hore-dbconnmodal-errormsg

pkdotson changed the title ~~chore(WIP): simplify error messaging in database modal~~ chore: simplify error messaging in database modal Mar 31, 2022

pkdotson added 2 commits March 31, 2022 15:30

add modal fix

ce0dbb2

Merge branch 'master' of https://github.com/preset-io/superset into c…

66d58a5

…hore-dbconnmodal-errormsg

pkdotson closed this Apr 1, 2022

pkdotson reopened this Apr 1, 2022

update comments

10c6771

AAfghahi approved these changes Apr 12, 2022

View reviewed changes

pkdotson added 4 commits April 12, 2022 14:39

Merge branch 'master' of https://github.com/preset-io/superset into c…

3532f33

…hore-dbconnmodal-errormsg

Merge branch 'master' of https://github.com/preset-io/superset into c…

11865ca

…hore-dbconnmodal-errormsg

Merge branch 'master' of https://github.com/preset-io/superset into c…

ddbd832

…hore-dbconnmodal-errormsg

Merge branch 'master' of https://github.com/preset-io/superset into c…

19e1f58

…hore-dbconnmodal-errormsg

pkdotson added 5 commits April 15, 2022 17:02

fix err msg bugs

1c9fb78

Merge branch 'master' of https://github.com/preset-io/superset into c…

90c9591

…hore-dbconnmodal-errormsg

fix pylint

e08c143

fix line

8566c56

fix tests

b21a488

pull-request-size bot added size/L and removed size/M labels Apr 18, 2022

pkdotson added 2 commits April 18, 2022 16:38

fix assertions

6a95ab2

Merge branch 'master' of https://github.com/preset-io/superset into c…

ee1a240

…hore-dbconnmodal-errormsg

Merge branch 'master' of https://github.com/preset-io/superset into c…

37b500b

…hore-dbconnmodal-errormsg

hughhhh approved these changes Apr 21, 2022

View reviewed changes

hughhhh merged commit ad71542 into apache:master Apr 21, 2022

diegomedina248 mentioned this pull request May 10, 2022

fix: The dynamic form to connect to Snowflake DB is not returning any errors #20013

Merged

9 tasks

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: simplify error messaging in database modal #19165

chore: simplify error messaging in database modal #19165

pkdotson commented Mar 16, 2022 •

edited

Loading

pkdotson commented Mar 16, 2022

github-actions bot commented Mar 16, 2022

codecov bot commented Mar 31, 2022 •

edited

Loading

github-actions bot commented Apr 1, 2022

pkdotson commented Apr 1, 2022

yousoph commented Apr 1, 2022

github-actions bot commented Apr 1, 2022

github-actions bot commented Apr 1, 2022

AAfghahi Apr 12, 2022

pkdotson Apr 18, 2022

yousoph commented Apr 20, 2022

github-actions bot commented Apr 20, 2022

github-actions bot commented Apr 21, 2022

chore: simplify error messaging in database modal #19165

chore: simplify error messaging in database modal #19165

Conversation

pkdotson commented Mar 16, 2022 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

pkdotson commented Mar 16, 2022

github-actions bot commented Mar 16, 2022

codecov bot commented Mar 31, 2022 • edited Loading

Codecov Report

github-actions bot commented Apr 1, 2022

pkdotson commented Apr 1, 2022

yousoph commented Apr 1, 2022

github-actions bot commented Apr 1, 2022

github-actions bot commented Apr 1, 2022

AAfghahi Apr 12, 2022

Choose a reason for hiding this comment

pkdotson Apr 18, 2022

Choose a reason for hiding this comment

yousoph commented Apr 20, 2022

github-actions bot commented Apr 20, 2022

github-actions bot commented Apr 21, 2022

pkdotson commented Mar 16, 2022 •

edited

Loading

codecov bot commented Mar 31, 2022 •

edited

Loading