-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart #19122
fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart #19122
Conversation
…d report is added again into dashboard or chart
Codecov Report
@@ Coverage Diff @@
## master #19122 +/- ##
==========================================
- Coverage 66.63% 66.62% -0.02%
==========================================
Files 1670 1671 +1
Lines 64570 64563 -7
Branches 6504 6506 +2
==========================================
- Hits 43028 43014 -14
- Misses 19858 19865 +7
Partials 1684 1684
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…rrorBoundInput component
…d report is added again into dashboard or chart (#19122) * fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart * fix(export-add): make to setup the default error message * fix(report-add): make to allow the errorMessage undefined in LabeledErrorBoundInput component (cherry picked from commit cb03570)
…d report is added again into dashboard or chart (apache#19122) * fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart * fix(export-add): make to setup the default error message * fix(report-add): make to allow the errorMessage undefined in LabeledErrorBoundInput component
SUMMARY
Attach new report to the dashboard again, but there are no error messages on the page #18225
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
https://user-images.githubusercontent.com/47900232/158206908-7a8fe15e-31cf-4049-b7db-395d0755cecf.mov
AFTER:
TESTING INSTRUCTIONS
How to reproduce the bug
ADDITIONAL INFORMATION