-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(big-number): Big Number with Trendline Chart is not working if Time Grain is set to Month #19043
Conversation
…me Grain is set to Month
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this @stephenLYZ ! I believe we should do the same for the other grains, too, like P3M
which should probably be QS
. Thoughts?
@villebro Good catch! Looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing!
Btw. It's a good way to move the entire AA control to here in order to maintain uniformity and reduce additional issues. @zhaoyongjie cc |
Codecov Report
@@ Coverage Diff @@
## master #19043 +/- ##
==========================================
- Coverage 66.58% 66.49% -0.09%
==========================================
Files 1641 1641
Lines 63533 63476 -57
Branches 6424 6444 +20
==========================================
- Hits 42303 42211 -92
- Misses 19551 19601 +50
+ Partials 1679 1664 -15
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
🏷️ preset:2022.9 |
Thanks for the fix. |
SUMMARY
This PR fixes the issue that Big Number with Trendline Chart is not working if Time Grain is set to Month and Rolling Function is set to
cumsum
.refer https://pandas.pydata.org/pandas-docs/stable/user_guide/timeseries.html#offset-aliases
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
2022-03-07.4.13.38.mov
after
2022-03-07.4.12.34.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION