Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Native Filter): User can create parent filters using "Filter is hierarchical #18915

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

jinghua-qa
Copy link
Member

add new native filter test: User can create parent filters using "Filter is hierarchical

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #18915 (1af1411) into master (8d38675) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18915   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files        1640     1640           
  Lines       63509    63512    +3     
  Branches     6417     6417           
=======================================
+ Hits        42167    42170    +3     
  Misses      19681    19681           
  Partials     1661     1661           
Flag Coverage Δ
javascript 51.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/SqlLab/components/ColumnElement/index.tsx 93.75% <0.00%> (+0.41%) ⬆️
superset-frontend/src/chart/Chart.jsx 53.44% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d38675...1af1411. Read the comment docs.

fix failed

add dependency

fix lint

fix test failure

fix failure

fix lint again
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI pass.

@jinghua-qa jinghua-qa merged commit 2bd8d3b into apache:master Feb 25, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
…hierarchical (#18915)

* add new native test for parent filter

(cherry picked from commit 2bd8d3b)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io Preset-QA size/L 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants