Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update standalone url for slack reports #18756

Merged
merged 3 commits into from
Feb 17, 2022
Merged

fix: update standalone url for slack reports #18756

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25e0c95
update url for slack reports
hughhhh Feb 16, 2022
903aa4e
fix test
hughhhh Feb 16, 2022
fda885d
update text to be dynamic
hughhhh Feb 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update text to be dynamic
  • Loading branch information
@hughhhh
hughhhh committed Feb 17, 2022
commit fda885d2474dcf62feae3ec62737f34390fa9c0d
7 changes: 3 additions & 4 deletions tests/integration_tests/reports/commands_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,11 +1119,10 @@ def test_slack_chart_report_schedule_with_text(
| 0 | c11 | c12 | c13 |
| 1 | c21 | c22 | c23 |"""
assert table_markdown in post_message_mock.call_args[1]["text"]

print(post_message_mock.call_args[1]["text"])
assert (
f"http://0.0.0.0:8080/superset/explore/?form_data=%7B%22slice_id%22%3A%201%7D&standalone=0&force=false"
) in post_message_mock.call_args[1]["text"]
f"<http://0.0.0.0:8080/superset/explore/?form_data=%7B%22slice_id%22%3A%20{create_report_slack_chart_with_text.chart.id}%7D&standalone=0&force=false|Explore in Superset>"
in post_message_mock.call_args[1]["text"]
)

# Assert logs are correct
assert_log(ReportState.SUCCESS)
Expand Down