Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only redirect to relative paths when authentication expires #18714

Merged
merged 2 commits into from
Feb 15, 2022
Merged

fix: Only redirect to relative paths when authentication expires #18714

merged 2 commits into from
Feb 15, 2022

Conversation

geido
Copy link
Member

@geido geido commented Feb 14, 2022

SUMMARY

This PR changes the next param used by FAB to redirect the user to the original page after logging back in due to token expiration. The full URL was used before but that should be unnecessary. This PR changes that and passes only the relative path as next param.

TESTING INSTRUCTIONS

  1. Do any action on the application after the token has expired
  2. Make sure that after login you are redirected to the original page

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #18714 (bde7b69) into master (42d97fb) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head bde7b69 differs from pull request most recent head c5133cb. Consider uploading reports for the commit c5133cb to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18714   +/-   ##
=======================================
  Coverage   66.34%   66.34%           
=======================================
  Files        1619     1619           
  Lines       62941    62961   +20     
  Branches     6343     6354   +11     
=======================================
+ Hits        41756    41772   +16     
+ Misses      19533    19529    -4     
- Partials     1652     1660    +8     
Flag Coverage Δ
javascript 51.34% <50.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 35.89% <ø> (ø)
superset-frontend/src/chart/ChartRenderer.jsx 44.89% <ø> (ø)
...erset-frontend/src/components/EmptyState/index.tsx 61.53% <ø> (+25.64%) ⬆️
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 3.75% <0.00%> (-0.20%) ⬇️
...ColumnSelectControl/ColumnSelectPopoverTrigger.tsx 65.51% <ø> (ø)
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 38.09% <ø> (ø)
superset-frontend/src/chart/Chart.jsx 51.78% <50.00%> (-0.07%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 75.29% <50.00%> (-1.25%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 80.86% <50.00%> (-1.70%) ⬇️
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 76.28% <50.00%> (-2.07%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d97fb...c5133cb. Read the comment docs.

@geido
Copy link
Member Author

geido commented Feb 15, 2022

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.216.21.100:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit 8027f5f into apache:master Feb 15, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants