-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Only redirect to relative paths when authentication expires #18714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #18714 +/- ##
=======================================
Coverage 66.34% 66.34%
=======================================
Files 1619 1619
Lines 62941 62961 +20
Branches 6343 6354 +11
=======================================
+ Hits 41756 41772 +16
+ Misses 19533 19529 -4
- Partials 1652 1660 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://34.216.21.100:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR changes the
next
param used by FAB to redirect the user to the original page after logging back in due to token expiration. The full URL was used before but that should be unnecessary. This PR changes that and passes only the relative path asnext
param.TESTING INSTRUCTIONS
ADDITIONAL INFORMATION