Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): add Mexico to country map viz #18007

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Jan 12, 2022

SUMMARY

Also updated the scripts for generating geojson to make it easier to use.

Some other maps were also updated possibly because we downloaded the latest map data.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Verified in storybook (yarn plugins:storbook):

Xnip2022-01-11_17-16-51

And chart creation:

Xnip2022-01-11_17-17-01

TESTING INSTRUCTIONS

Check Mexico is in available countries in Country Map vis.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Also updated the scripts for generating geojson to make it easier to use.

Some other maps were also updated possibly because we downloaded the latest map data.
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #18007 (67da6a0) into master (63ca09e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18007   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files        1569     1569           
  Lines       61660    61660           
  Branches     6232     6232           
=======================================
  Hits        40894    40894           
  Misses      19167    19167           
  Partials     1599     1599           
Flag Coverage Δ
javascript 50.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63ca09e...67da6a0. Read the comment docs.

@ktmud ktmud merged commit f451081 into apache:master Jan 12, 2022
@ktmud ktmud deleted the mexico-map branch January 12, 2022 16:41
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants