fix: dashboard reload crash #17992
Merged
fix: dashboard reload crash #17992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
approved these changes
Jan 11, 2022
|
For anyone wondering what this PR is about, we're seeing a weirdly erratic error on one particular example dashboard on our deployments, that's happening at this particular location in these lines. We're hopeful that this little safety check will resolve it 🤞, and will upload before/after screenshots if it works. |
Codecov Report
@@ Coverage Diff @@
## master #17992 +/- ##
=======================================
Coverage 67.05% 67.05%
=======================================
Files 1612 1612
Lines 64999 64999
Branches 6872 6872
=======================================
Hits 43586 43586
Misses 19546 19546
Partials 1867 1867
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rosemarie-chiu
pushed a commit
to preset-io/superset
that referenced
this pull request
Jan 11, 2022
* fix dashboard reload * add more strict case (cherry picked from commit 3d829fc)
eschutho
pushed a commit
that referenced
this pull request
Jan 27, 2022
* fix dashboard reload * add more strict case
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* fix dashboard reload * add more strict case
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* fix dashboard reload * add more strict case
mistercrunch
added
🍒 1.4.1
🍒 1.4.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Possible fix for issue where the gridcomponent might be undefined causing dashboard to crash.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION