Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update slug name #17961

Merged
merged 2 commits into from
Jan 7, 2022
Merged

fix: update slug name #17961

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77cc7b3
fix: fix update slug name
pkdotson Jan 7, 2022
7f5af3e
Update superset-frontend/src/dashboard/components/nativeFilters/Filte…
pkdotson Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,9 @@ const FilterBar: React.FC<FiltersBarProps> = ({
}
newParams.set(URL_PARAMS.nativeFiltersKey.name, dataMaskKey);

// pathname could be updated somewhere else through windows.history
pkdotson marked this conversation as resolved.
Show resolved Hide resolved
// keep react router history in sync with window history
history.location.pathname = window.location.pathname;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this problem happen elsewhere too? Is there a global solution for it?

history.replace({
search: newParams.toString(),
});
Expand Down