refactor(storybok): upgrade to webpack5 in storybook of plugins #17909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17909 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 1609 1609
Lines 64903 64903
Branches 6866 6866
=======================================
Hits 43535 43535
Misses 19502 19502
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
approved these changes
Jan 4, 2022
...d/packages/superset-ui-demo/storybook/stories/superset-ui-chart/ChartDataProviderStories.tsx
Show resolved
Hide resolved
9 tasks
zhaoyongjie
force-pushed
the
refactor_storybok
branch
from
669da54
to
d2f038c
Compare
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
…he#17909) * refactor: use webpack5 in plugins storybook * remove ./src from packages.json
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
…he#17909) * refactor: use webpack5 in plugins storybook * remove ./src from packages.json
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently, We used the config of Webpack4 in Storybook even though Superset has upgraded to webpack5. This PR intends to upgrade Webpack config in Storybook.
file-loaderwithasset/resourceingeojson files import./srcfrompackage.jsonBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
CI
ADDITIONAL INFORMATION