Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storybok): upgrade to webpack5 in storybook of plugins #17909

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jan 3, 2022

SUMMARY

Currently, We used the config of Webpack4 in Storybook even though Superset has upgraded to webpack5. This PR intends to upgrade Webpack config in Storybook.

  1. replace file-loader with asset/resource in geojson files import
  2. upgrade config of Storybook
  3. import module of superset-ui from single point
  4. remove the dependency of ./src from package.json
  5. fix potential errors of TS

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #17909 (d2f038c) into master (de3d397) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17909   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files        1609     1609           
  Lines       64903    64903           
  Branches     6866     6866           
=======================================
  Hits        43535    43535           
  Misses      19502    19502           
  Partials     1866     1866           
Flag Coverage Δ
javascript 53.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de3d397...d2f038c. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one optional suggestion

@zhaoyongjie zhaoyongjie mentioned this pull request Jan 4, 2022
9 tasks
@zhaoyongjie zhaoyongjie merged commit 97a78d3 into apache:master Jan 5, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
…he#17909)

* refactor: use webpack5 in plugins storybook

* remove ./src from packages.json
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
…he#17909)

* refactor: use webpack5 in plugins storybook

* remove ./src from packages.json
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants