Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Moves the hooks folder to the src folder #17896

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Moves the hooks folder to the src folder.

This work is part of SIP-61

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #17896 (f4e6be4) into master (8ebec60) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17896   +/-   ##
=======================================
  Coverage   67.10%   67.10%           
=======================================
  Files        1609     1609           
  Lines       64897    64897           
  Branches     6866     6866           
=======================================
  Hits        43547    43547           
  Misses      19484    19484           
  Partials     1866     1866           
Flag Coverage Δ
javascript 53.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/dashboard/containers/DashboardPage.tsx 25.24% <ø> (ø)
...nd/src/explore/components/ExploreViewContainer.jsx 2.32% <ø> (ø)
...mponents/controls/MetricControl/MetricsControl.jsx 35.16% <ø> (ø)
...et-frontend/src/hooks/apiResources/apiResources.ts 85.71% <ø> (ø)
superset-frontend/src/hooks/apiResources/charts.ts 57.14% <ø> (ø)
...rset-frontend/src/hooks/apiResources/dashboards.ts 40.00% <ø> (ø)
superset-frontend/src/hooks/apiResources/index.ts 100.00% <ø> (ø)
...perset-frontend/src/hooks/useChangeEffect/index.ts 100.00% <ø> (ø)
...ntend/src/hooks/useChangeEffect/useChangeEffect.ts 100.00% <ø> (ø)
...t-frontend/src/hooks/useComponentDidMount/index.ts 100.00% <ø> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebec60...f4e6be4. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 53d8d38 into apache:master Jan 7, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants