Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): simple tab content input problem in the filter control #17872

Merged
merged 3 commits into from
Jan 3, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR fixes the simple tab content input problem. Currently the content cursor jumps to the end after input. See the video.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2021-12-26.7.23.02.mov

after

2021-12-26.7.23.43.mov

TESTING INSTRUCTIONS

  1. Go to explore
  2. Create a filter
  3. Enter in filter value
  4. See the error

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #17872 (e8dd3d9) into master (4954d52) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17872      +/-   ##
==========================================
- Coverage   67.08%   67.07%   -0.01%     
==========================================
  Files        1609     1609              
  Lines       64897    64899       +2     
  Branches     6866     6866              
==========================================
  Hits        43533    43533              
- Misses      19498    19500       +2     
  Partials     1866     1866              
Flag Coverage Δ
javascript 53.77% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 66.18% <0.00%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4954d52...e8dd3d9. Read the comment docs.

@stephenLYZ stephenLYZ closed this Dec 27, 2021
@stephenLYZ stephenLYZ reopened this Dec 27, 2021
@stephenLYZ stephenLYZ closed this Dec 28, 2021
@stephenLYZ stephenLYZ reopened this Dec 28, 2021
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the fix

@zhaoyongjie zhaoyongjie merged commit 07998fe into apache:master Jan 3, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants