-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: fix(time_picker): Fix incorrect time range display #17816
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17816 +/- ##
==========================================
+ Coverage 66.67% 66.73% +0.06%
==========================================
Files 1738 1587 -151
Lines 65078 63954 -1124
Branches 6885 6864 -21
==========================================
- Hits 43391 42682 -709
+ Misses 19939 19408 -531
- Partials 1748 1864 +116
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @zhaoyongjie, I had marked last review as resolved since I had replied there. Please consider merging this commit. |
UPDATE: master had modified |
Since #18936 had removed SIP-15 related logics, including this endpoint config. I should recheck if this bug still exists and may create another issue. |
This bug was fixed in version 1.5.1, closing this PR. |
SUMMARY
This fixes #16462. It will correct time range display from
(begin, end)
to[begin, end)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE(copied from issue):
AFTER:
TESTING INSTRUCTIONS
Just create a dashboard with a time range filter and confirm time range is
[begin, end)
ADDITIONAL INFORMATION