Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated screenshots in README.md and added recent events #17650

Merged
merged 10 commits into from
Dec 17, 2021

Conversation

srinify
Copy link
Contributor

@srinify srinify commented Dec 4, 2021

Updated screenshots in README.MD:

gallery

slack_dash

Added some database logos:

firebolt
timescale
rockset

@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #17650 (fafefd2) into master (f396818) will not change coverage.
The diff coverage is n/a.

❗ Current head fafefd2 differs from pull request most recent head 159b59b. Consider uploading reports for the commit 159b59b to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17650   +/-   ##
=======================================
  Coverage   67.18%   67.18%           
=======================================
  Files        1609     1609           
  Lines       64796    64796           
  Branches     6855     6855           
=======================================
  Hits        43530    43530           
  Misses      19410    19410           
  Partials     1856     1856           
Flag Coverage Δ
javascript 53.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f396818...159b59b. Read the comment docs.

README.md Outdated Show resolved Hide resolved
README.md Outdated
- A **lightweight semantic layer** for quickly defining custom dimensions and metrics
- Out of the box support for **nearly any SQL** database or data engine
- A wide array of **beautiful visualizations** to showcase your data
metadata browser
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line looks wrong... is this a separate item?

README.md Outdated

<kbd><img title="View Dashboards" src="superset-frontend/src/assets/images/screenshots/slack_dash.jpg"/></kbd><br/>

**Slice & dice your data**
**No Code Chart Builder**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**No Code Chart Builder**
**No-Code Chart Builder**

This seems like it should be hyphenated. Maybe. ¯\_(ツ)_/¯

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@riahk riahk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're in here, we should remove/update (though I'm not sure it's needed anymore?) the Dependencies Status link at the top of the page, as the image is currently broken and the link doesn't go anywhere:
Screen Shot 2021-12-07 at 9 09 14 AM

@srinify srinify mentioned this pull request Dec 12, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srinify srinify merged commit 53e2fa6 into apache:master Dec 17, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
…he#17650)

* chore: updated screenshots in readme.md and added recent events

* chore: updated pinot superset connection instructions

* fixed outdated slack link

* addressed all outstanding feedback!

* updated package lock

* reverted package.json to master

* Update README.md

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
…he#17650)

* chore: updated screenshots in readme.md and added recent events

* chore: updated pinot superset connection instructions

* fixed outdated slack link

* addressed all outstanding feedback!

* updated package lock

* reverted package.json to master

* Update README.md

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants