-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated screenshots in README.md and added recent events #17650
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17650 +/- ##
=======================================
Coverage 67.18% 67.18%
=======================================
Files 1609 1609
Lines 64796 64796
Branches 6855 6855
=======================================
Hits 43530 43530
Misses 19410 19410
Partials 1856 1856
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
README.md
Outdated
- A **lightweight semantic layer** for quickly defining custom dimensions and metrics | ||
- Out of the box support for **nearly any SQL** database or data engine | ||
- A wide array of **beautiful visualizations** to showcase your data | ||
metadata browser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line looks wrong... is this a separate item?
README.md
Outdated
|
||
<kbd><img title="View Dashboards" src="superset-frontend/src/assets/images/screenshots/slack_dash.jpg"/></kbd><br/> | ||
|
||
**Slice & dice your data** | ||
**No Code Chart Builder** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**No Code Chart Builder** | |
**No-Code Chart Builder** |
This seems like it should be hyphenated. Maybe. ¯\_(ツ)_/¯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Evan Rusackas <evan@preset.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…he#17650) * chore: updated screenshots in readme.md and added recent events * chore: updated pinot superset connection instructions * fixed outdated slack link * addressed all outstanding feedback! * updated package lock * reverted package.json to master * Update README.md Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Evan Rusackas <evan@preset.io>
…he#17650) * chore: updated screenshots in readme.md and added recent events * chore: updated pinot superset connection instructions * fixed outdated slack link * addressed all outstanding feedback! * updated package lock * reverted package.json to master * Update README.md Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Evan Rusackas <evan@preset.io>
Updated screenshots in README.MD:
Added some database logos: