-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Change 500 error to 422 in Sql Lab #17292
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17292 +/- ##
==========================================
+ Coverage 76.96% 76.97% +0.01%
==========================================
Files 1037 1037
Lines 55606 55616 +10
Branches 7588 7588
==========================================
+ Hits 42796 42811 +15
+ Misses 12560 12555 -5
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Can we get a test to verify this in python? |
@hughhhh 100% I was going to do that when I got back :) |
/testenv up |
@eschutho Ephemeral environment spinning up at http://54.245.154.1:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no existing tests for the api endpoint so @AAfghahi will fast follow with a new test in a separate PR
I tested it on the ephemeral and got the expected results. |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
The stop query function is currently only enabled for certain databases and not others. Currently we are sending a 500 Error when a user hits the stop query button. This PR changes that to a 422 while we enable the feature for all databases.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Run a query in Athena (or anything not postgres or mysql)
hit the stop query button
check network tab.
ADDITIONAL INFORMATION