Skip to content

Conversation

gnought
Copy link
Contributor

@gnought gnought commented Oct 29, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing

Hi @gnought, do you mind fixing the code style?

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #17289 (8113b3a) into master (59a6502) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17289      +/-   ##
==========================================
+ Coverage   77.10%   77.18%   +0.07%     
==========================================
  Files        1036     1036              
  Lines       55672    55671       -1     
  Branches     7627     7627              
==========================================
+ Hits        42925    42968      +43     
+ Misses      12491    12447      -44     
  Partials      256      256              
Flag Coverage Δ
hive 81.57% <ø> (-0.01%) ⬇️
mysql 82.00% <ø> (-0.01%) ⬇️
postgres 82.01% <ø> (-0.01%) ⬇️
presto 81.87% <ø> (?)
python 82.51% <ø> (+0.15%) ⬆️
sqlite 81.68% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/base.py 74.91% <ø> (-0.09%) ⬇️
superset/models/core.py 90.00% <0.00%> (+0.73%) ⬆️
superset/connectors/sqla/models.py 87.39% <0.00%> (+1.40%) ⬆️
superset/db_engine_specs/presto.py 90.37% <0.00%> (+6.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59a6502...8113b3a. Read the comment docs.

@gnought
Copy link
Contributor Author

gnought commented Nov 3, 2021

LGTM! Thanks for fixing

Hi @gnought, do you mind fixing the code style?

Fixed. :)

@zhaoyongjie zhaoyongjie merged commit 4e9f812 into apache:master Nov 4, 2021
@gnought gnought deleted the gnought-patch-1 branch November 13, 2021 14:22
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* Removed redundant logger defintion

* Fixed code style
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 First shipped in 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0 First shipped in 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants