-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updated connection string for Firebolt #17242
fix: Updated connection string for Firebolt #17242
Conversation
Hi Team! |
@villebro please guide. Thanks! |
Sure @raghavSharmaSigmoid! Can you rebase the PR? it seems there are multiple conflicts here |
Sure. Thanks for the reply. |
@villebro , all checks have passed. Can you merge the PR ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
* New branch from superset for integration with firebolt sqlalchemy adapter * Added db_engine_spec file for Firebolt * Removed firebolt code from superset repo * Deleted virtual env commit * Adding time grain changes to firebolt.py * Updated README.md Added steps to install and run Superset with Firebolt SQLAlchemy Adapter * Update README.md Reduced installation steps. Using PyPi installation for adapter now * Revert "Update README.md" This reverts commit 5ed17c7. * Revert "Updated README.md" This reverts commit 45c5072. * added epoch methods, added test cases for firebolt db engine spec and edited setup.py * Added license to files * Added documentation for Firebolt-SQLAlchemy * Removed trailing whitespace * Updated connection string for Firebolt Co-authored-by: apurva-sigmoid <89530372+apurva-sigmoid@users.noreply.github.com> Co-authored-by: Apurva Anand <aapurva@sigmoidanalytics.com>
fix: Updated connection string for Firebolt