-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove variables from styled component #17228
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17228 +/- ##
==========================================
+ Coverage 76.82% 76.97% +0.14%
==========================================
Files 1038 1037 -1
Lines 55597 55635 +38
Branches 7585 7594 +9
==========================================
+ Hits 42715 42825 +110
+ Misses 12632 12560 -72
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pkdotson it appears you might have some to remove from this file too superset-frontend/src/dashboard/components/menu/HoverMenu.tsx
. Thanks!
* remove variables * fix hovermenu styles
SUMMARY
This pr remove less vars from styled component in the dashboard builder and hovermenu
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-10-25.at.9.36.15.PM.mov
TESTING INSTRUCTIONS
Go to dashboard builder and check that styles are applied when user hovers over row within and column or row within tabs.
ADDITIONAL INFORMATION