Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dashboard): Sidepanel positioning #17200

Merged
merged 5 commits into from
Nov 2, 2021
Merged

fix(Dashboard): Sidepanel positioning #17200

merged 5 commits into from
Nov 2, 2021

Conversation

geido
Copy link
Member

@geido geido commented Oct 22, 2021

SUMMARY

This PR fixes several positioning issues with the sidepanel in Dashboard.

Fixes #17158

BEFORE

See #17158

AFTER

Video.Game.Sales.mp4

TESTING INSTRUCTIONS

  1. Open a Dashboard
  2. Scroll at the bottom
  3. Edit the Dashboard
  4. Make sure the sidepanel is showing properly

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #17200 (8eac7af) into master (860e481) will increase coverage by 0.12%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17200      +/-   ##
==========================================
+ Coverage   76.94%   77.06%   +0.12%     
==========================================
  Files        1039     1037       -2     
  Lines       55580    55671      +91     
  Branches     7575     7607      +32     
==========================================
+ Hits        42764    42904     +140     
+ Misses      12566    12517      -49     
  Partials      250      250              
Flag Coverage Δ
javascript 71.26% <88.88%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/components/DashboardBuilder/DashboardBuilder.tsx 90.51% <81.81%> (+0.33%) ⬆️
.../src/dashboard/components/BuilderComponentPane.tsx 96.87% <93.33%> (-3.13%) ⬇️
superset-frontend/src/dashboard/util/constants.ts 100.00% <100.00%> (ø)
...erset-frontend/src/components/Pagination/index.tsx 72.72% <0.00%> (-27.28%) ⬇️
...Filters/FilterBar/FilterControls/FilterControl.tsx 94.87% <0.00%> (-5.13%) ⬇️
...mponents/controls/MetricControl/MetricsControl.jsx 38.18% <0.00%> (-3.88%) ⬇️
...tend/src/filters/components/Select/controlPanel.ts 58.33% <0.00%> (-3.21%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 87.13% <0.00%> (-0.59%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 68.30% <0.00%> (-0.41%) ⬇️
...et-frontend/src/components/TableSelector/index.tsx 74.28% <0.00%> (-0.25%) ⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 860e481...8eac7af. Read the comment docs.

@geido geido marked this pull request as ready for review October 25, 2021 11:08
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor bycatch related to a variable used here. LGTM and works great in testing, but would really prefer to get @michael-s-molina or @kgabryje to sign off on the styling part.

@pkdotson
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@pkdotson Ephemeral environment spinning up at http://54.185.33.35:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido requested a review from kgabryje October 29, 2021 15:24
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@geido geido merged commit a2a457b into apache:master Nov 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021

Ephemeral environment shutdown and build artifacts deleted.

AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
* Refactor

* Adjust top offset

* Calculate padding chart list

* Check for standalone mode

* Rename standaloneMode
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 1.5.0
Projects
None yet
5 participants