chore(druid): Explicitly cast col to TIMESTAMP #17101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This speaks somewhat to SIP-15A and the proof-of-concept defined in #7682, but in theory any column in Druid (and not just
__time
which is of typeTIMESTAMP
) could be used as the temporal column and thus should first be converted to aTIMESTAMP
.This PR replicates the Presto logic which leveraging
CAST(x AS TIMESTAMP)
which works whenx
is aDATE
,TIMESTAMP
orSTRING
(these adhere to the ISO 8601 format per the column "DATETIME FORMAT"), i.e.,Long term it would be good to implement something similar to the proof-of-concept to bring clarity to the various transforms and type conversions which are needed for both the left- and right-hand-side of a comparator.
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION